fix: update TypeScript types #1805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overhauls the types so that they actually work for Vue 3, being primarily based on the prop types for each component/mixin and tested locally using a project of mine.
They're by no means perfect but they'll mean type checking actually works properly and they can be refined over time - unfortunately I'm not sure if it'll be possible to strictly type everything due to the large degree of freedom around handling object-type options (i.e.
trackByandlabel, which in theory should be supportable with generics, except with the way Vue types work I'm not sure it'll be possible to actually properly pass generics around), but this should at least get the ball rolling.As I've only just started exploring this library, I'm happy to be told if a prop should be of a particular type.