Add mutate3 command using Expr language #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrites the copied mutate2 command to use Expr. With the goal of writing unit tests, I created a mutate3Opts struct and moved the core logic into a separate `doMutate3()` function.
|
It's a mazing, appreciate it! @moorereason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting this PR so that others can evaluate the Expr language engine.
I intentionally made the first commit in this PR so that it would be a little easier to see that I mostly just copied the
mutate2.gofile. The second commit is a little noisy since I moved the core logic into a separate function, which made unit testing must simpler.Thanks for evaluating this PR.
Updates #172