Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test exception with message #131

Merged
merged 7 commits into from
Aug 17, 2023
Merged

Add test exception with message #131

merged 7 commits into from
Aug 17, 2023

Conversation

facug91
Copy link
Contributor

@facug91 facug91 commented Aug 15, 2023

Solves issue #130

@facug91
Copy link
Contributor Author

facug91 commented Aug 15, 2023

I tested this on Ubuntu 20 and it worked fine. I seem to be missing something for Windows 😅. Sorry, I'll check this out later.

@sheredom
Copy link
Owner

Windows seems fine - but there is some UBSAN issue.

@facug91
Copy link
Contributor Author

facug91 commented Aug 16, 2023

In my computer the sanitizer is failing even in master. In the CI it is failing with use-of-uninitialized-value, but I just added message_caught which is initialized with the value UTEST_NULL, and message_size which is initialized with strlen(e.what()) + 1. I can't find the problem.
I've been reading on stackoverflow that MemorySanitizer sometimes returns false positives for this, but I'm not sure this is the case. Can you help me please @sheredom? I am a bit lost.

@sheredom
Copy link
Owner

Trying to work this out at the minute in the other PR (with some choice language, its just for testing as I don't have Linux locally setup at present!) #132

@facug91
Copy link
Contributor Author

facug91 commented Aug 17, 2023

I see in your commits in the other PR, that it seems to be a problem with the compiler. I made a commit to disable the test like you did, but only for test.cpp, which is the file that was failing here. If I see that it also fails in the others, I will disable it in those files as well. Thank you!

@sheredom
Copy link
Owner

Yeah @facug91 it seems like this is the same GLIBC cstdlib sanitizer bug - pretty hard to track down!

@sheredom sheredom merged commit 369a57c into sheredom:master Aug 17, 2023
48 checks passed
@sheredom
Copy link
Owner

Good work getting this through!

@facug91 facug91 deleted the add-test-exception-with-message branch August 20, 2023 19:39
@facug91 facug91 restored the add-test-exception-with-message branch August 20, 2023 19:39
@facug91 facug91 deleted the add-test-exception-with-message branch August 20, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants