isolate tests in child processes #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheredom
reviewed
May 27, 2024
utest.h
Outdated
| @@ -33,6 +33,10 @@ | |||
| #ifndef SHEREDOM_UTEST_H_INCLUDED | |||
| #define SHEREDOM_UTEST_H_INCLUDED | |||
|
|
|||
| #include <cstdlib> | |||
There was a problem hiding this comment.
You are gonna run into some nasty cross platform issues here I'd bet!
There was a problem hiding this comment.
yes I think cross platform compatibility will be a problem. I will check if there is a solution for that.
utest.h
Outdated
| @@ -1554,21 +1558,43 @@ int utest_main(int argc, const char *const argv[]) { | |||
|
|
|||
| ns = utest_ns(); | |||
| errno = 0; | |||
|
|
|||
| pid_t pid = fork(); | |||
There was a problem hiding this comment.
We'll need to do some perf testing to see how much slower this is (I suspect it might be).
Peyman-EsteghamatRad
force-pushed
the
feature/test-isolation
branch
from
1e13336
to
7fa4a36
Compare
Peyman-EsteghamatRad
force-pushed
the
feature/test-isolation
branch
from
7fa4a36
to
b0638c6
Compare
…Rad/utest.h into feature/test-isolation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR testcases are isolated in single processes. This allows to keep executing all testcases even if some tests fail due to an unhandled signal (e.g. SIGSEGV).