OfferMessage を更新する #143
Merged
OfferMessage を更新する #143
+35
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zztkm
commented
Dec 18, 2024
There was a problem hiding this comment.
channel_id や multistream などのオプショナルでない項目は確定で入ってくることを前提にしていて、オプショナルにしてある項目は互換性担保の目的でオプショナルにしてあります。
There was a problem hiding this comment.
議論になる箇所と思うのですが、Sora の仕様変更の可能性を考えると、SDK として動作に必須でない（利用していない）項目は全てオプショナルにしてしまって良いように思いました。将来的に multistream が廃止されることなどを意識しています。
zztkm
commented
Dec 18, 2024
| @@ -111,15 +111,31 @@ data class RedirectMessage( | |||
| data class OfferMessage( | |||
| @SerializedName("type") val type: String = "offer", | |||
| @SerializedName("sdp") val sdp: String, | |||
| @SerializedName("version") val version: String, | |||
There was a problem hiding this comment.
[Q] version はオプションの方が良いかどうか
miosakuma
reviewed
Dec 18, 2024
sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/signaling/message/Catalog.kt
Outdated
Show resolved
Hide resolved
…/signaling/message/Catalog.kt Co-authored-by: miosakuma <[email protected]>
…uredo/sora-android-sdk into feature/upate-offer-message
miosakuma
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
versionmultistreamsimulcast_multicodecspotlightchannel_idsession_idaudioaudio_codec_typeaudio_bit_ratevideovideo_codec_typevideo_bit_rateThis pull request includes updates to the
OfferMessageclass and documentation changes to reflect the new fields added. The most important changes include the addition of several new fields to theOfferMessageclass and the corresponding update to theCHANGES.mdfile.Updates to
OfferMessageclass:version,multistream,simulcast_multicodec,spotlight,channel_id,session_id,audio,audio_codec_type,audio_bit_rate,video,video_codec_type, andvideo_bit_rateto theOfferMessageclass insora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/signaling/message/Catalog.kt.Documentation updates:
CHANGES.mdto include the new fields added toOfferMessage.