-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
マルチコーデックサイマルキャストの送信に対応する #10
Open
melpon
wants to merge
36
commits into
develop
Choose a base branch
from
feature/multicodec-simulcast-sendonly
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r0,r1,r2 に対応するコーデックを
a=rid:
の pt= に基づいて生成するようにしました。pt= が無い場合、最初に見つかった
a=rtpmap:
のコーデックを利用します(既存の動作と同じ)。This pull request includes several changes to the
examples/sumomo
files, focusing on improving the handling of optional parameters and updating the RTP (Real-time Transport Protocol) handling. It also includes updates to theCHANGES.md
file and several changes to theproto/soracp.proto
,include/sorac/
, andsrc/
directories.Updates to optional parameters handling:
examples/sumomo/option.c
: Added handling forvideo
andaudio
options in thelong_opts[]
struct and in thesumomo_option_parse
function. Also, aSET_OPTBOOL
macro was introduced to simplify setting boolean options. [1] [2] [3] [4] [5]examples/sumomo/option.h
: Addedvideo
andaudio
options to theSumomoOption
struct.examples/sumomo/sumomo.c
: Updated themain
function to setvideo
andaudio
options based on the parsed options.Updates to RTP handling:
examples/sumomo/sumomo.c
: Replacedrtp_encoding_parameters
withrtp_parameters
in theState
struct and updated theon_capture_frame
function to usertp_parameters
. [1] [2] [3]examples/sumomo/util.cpp
andexamples/sumomo/util.h
: Updated thesumomo_util_scale_simulcast
function to take ascales
array instead of anum_rids
integer. [1] [2]include/sorac/signaling.hpp
: Updated theGetRtpParameters
method in theSignaling
class.proto/soracp.proto
: Updated theRtpEncodingParameters
message and added theRtpParameters
message. [1] [2]src/signaling.cpp
: Updated theGetRtpParameters
method and the handling of RTP parameters in theSignalingImpl
class. [1] [2] [3]Other changes:
CHANGES.md
: Added entries for supporting multi-codec simulcast transmission and updatingprotoc-gen-jsonif
to support optional parameters.