Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sora CPP SDK の 2024.8.0-canary.26 の変更に対応 #111

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

torikizi
Copy link
Contributor

This pull request primarily focuses on updating the codebase to replace absl::optional and absl::nullopt with std::optional and std::nullopt respectively. These changes span across multiple files and functions to ensure consistency and compatibility with the updated Sora C++ SDK.

Key changes include:

SDK and Dependency Updates:

  • Updated Sora C++ SDK to version 2024.8.0, which includes changes from absl::optional to std::optional and from absl::nullopt to std::nullopt.

Decoder Changes:

  • Replaced absl::optional<int> with std::optional<int> in DynamicH264Decoder::Decode.
  • Updated the call to callback_->Decoded to use std::nullopt instead of absl::nullopt.

Encoder Changes:

  • Changed NumberOfThreads function to use std::optional<int> instead of absl::optional<int>.
  • Updated ScalabilityModeFromTemporalLayers to return std::optional<ScalabilityMode> and use std::nullopt. [1] [2]
  • Modified DynamicH264Encoder class to use std::optional for scalability_modes_ and encoder_thread_limit_ members.

Audio Handling Changes:

  • Updated SoraAudioSinkImpl::OnData and SoraAudioSourceInterface::OnData to use std::optional<int64_t> instead of absl::optional<int64_t>. [1] [2]
  • Changed SoraAudioSourceInterface::Add10MsData and SoraAudioSource::OnData to use std::optional<int64_t> and std::nullopt. [1] [2] [3]
  • Modified SoraAudioStreamSinkImpl::OnData to use std::optional<int64_t> instead of absl::optional<int64_t>.

These updates ensure that the codebase is aligned with the latest standards and improves overall maintainability and compatibility.

@torikizi torikizi requested a review from miosakuma November 25, 2024 07:12
Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました、対応ありがとうございます。

@torikizi
Copy link
Contributor Author

確認ありがとうございます。こちらマージします。

@torikizi torikizi merged commit 5a8aa1c into develop Nov 25, 2024
30 checks passed
@torikizi torikizi deleted the feature/update-sora-cpp-sdk-canary26 branch November 25, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants