Sora CPP SDK の 2024.8.0-canary.26 の変更に対応 #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on updating the codebase to replace
absl::optional
andabsl::nullopt
withstd::optional
andstd::nullopt
respectively. These changes span across multiple files and functions to ensure consistency and compatibility with the updated Sora C++ SDK.Key changes include:
SDK and Dependency Updates:
2024.8.0
, which includes changes fromabsl::optional
tostd::optional
and fromabsl::nullopt
tostd::nullopt
.Decoder Changes:
absl::optional<int>
withstd::optional<int>
inDynamicH264Decoder::Decode
.callback_->Decoded
to usestd::nullopt
instead ofabsl::nullopt
.Encoder Changes:
NumberOfThreads
function to usestd::optional<int>
instead ofabsl::optional<int>
.ScalabilityModeFromTemporalLayers
to returnstd::optional<ScalabilityMode>
and usestd::nullopt
. [1] [2]DynamicH264Encoder
class to usestd::optional
forscalability_modes_
andencoder_thread_limit_
members.Audio Handling Changes:
SoraAudioSinkImpl::OnData
andSoraAudioSourceInterface::OnData
to usestd::optional<int64_t>
instead ofabsl::optional<int64_t>
. [1] [2]SoraAudioSourceInterface::Add10MsData
andSoraAudioSource::OnData
to usestd::optional<int64_t>
andstd::nullopt
. [1] [2] [3]SoraAudioStreamSinkImpl::OnData
to usestd::optional<int64_t>
instead ofabsl::optional<int64_t>
.These updates ensure that the codebase is aligned with the latest standards and improves overall maintainability and compatibility.