transport-wide-cc-extensions-01 の出力に合わせてテストを変更する #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miosakuma
force-pushed
the
feature/fix-e2e-simulcast-encoder-adapter
branch
from
c86d0bf to
b37dad7
Compare
voluntas
reviewed
Dec 30, 2024
voluntas
reviewed
Dec 30, 2024
voluntas
approved these changes
Dec 30, 2024
voluntas
reviewed
Dec 30, 2024
tests/test_macos.py
Outdated
| @@ -89,7 +89,7 @@ def test_macos_simulcast(setup, video_codec_type, expected_implementation): | |||
| ) | |||
| sendonly.connect(fake_video=True) | |||
|
|
|||
| time.sleep(5) | |||
| time.sleep(10) | |||
voluntas
approved these changes
Dec 30, 2024
tests/test_openh264.py
Outdated
| @@ -101,7 +101,7 @@ def test_openh264_simulcast(setup, video_codec_type, expected_implementation): | |||
| ) | |||
| sendonly.connect(fake_video=True) | |||
|
|
|||
| time.sleep(5) | |||
| time.sleep(10) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sora 側の設定でトランスポートワイド輻輳制御を有効にしたところ、Stats の outbound-rtp の encoderImplementation が変わったため、テストが失敗しました。
Sora 側の設定は今後もトランスポートワイド輻輳制御を有効にするので設定に合わせてテスト結果の判定を修正します。
This pull request includes changes to the
tests/test_openh264.pyandtests/test_simulcast.pyfiles to update the expected implementation strings for various video codecs.Updates to expected implementation strings:
tests/test_openh264.py: Modified the expected implementation string for the "H264" codec in thetest_openh264_simulcasttest case to use a single instance ofOpenH264instead of three.tests/test_simulcast.py: Updated the expected implementation strings for the "VP8", "VP9", and "AV1" codecs in thetest_simulcasttest case to use a single instance of the respective codec libraries instead of three.