Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

メトリクスのテンポラリーノード対応 #42

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

tnamao
Copy link
Collaborator

@tnamao tnamao commented Jun 20, 2024

変更履歴

  • [ADD] sora_cluster_node のメトリクスに node_type を追加する
    • regular または temporary のいずれかが入ります
    • @tnamao

This pull request primarily introduces a new node_type attribute to the sora_cluster_node metrics in the Sora server. This attribute can either be regular or temporary, depending on whether the node is a temporary one. The changes also include updates to the test data and metrics files to reflect this new attribute.

Here are the key changes:

Updates to sora_cluster_node metrics:

  • collector/cluster_node.go: The node_type attribute was added to the soraClusterMetrics variable, and the logic to determine the node_type was added to the Collect method of SoraClusterMetrics. [1] [2]
  • collector/sora_api.go: The soraClusterNode struct was updated to include the TemporaryNode boolean attribute.

Updates to test data:

Updates to metrics files:

  • test/maximum.metrics and test/sora_cluster_metrics_enabled.metrics: The sora_cluster_node metrics were updated to include the node_type attribute. [1] [2]

Documentation update:

  • CHANGES.md: The addition of the node_type attribute to the sora_cluster_node metrics was documented.

@tnamao
Copy link
Collaborator Author

tnamao commented Jun 20, 2024

マージします

@tnamao tnamao merged commit f3c1051 into develop Jun 20, 2024
2 checks passed
@tnamao tnamao deleted the feature/temporary-node-label branch June 20, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant