Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更履歴
sora_cluster_node
のメトリクスにnode_type
を追加するregular
またはtemporary
のいずれかが入りますThis pull request primarily introduces a new
node_type
attribute to thesora_cluster_node
metrics in the Sora server. This attribute can either beregular
ortemporary
, depending on whether the node is a temporary one. The changes also include updates to the test data and metrics files to reflect this new attribute.Here are the key changes:
Updates to
sora_cluster_node
metrics:collector/cluster_node.go
: Thenode_type
attribute was added to thesoraClusterMetrics
variable, and the logic to determine thenode_type
was added to theCollect
method ofSoraClusterMetrics
. [1] [2]collector/sora_api.go
: ThesoraClusterNode
struct was updated to include theTemporaryNode
boolean attribute.Updates to test data:
main_test.go
: The test data was updated to include thetemporary_node
attribute. [1] [2] [3] [4]Updates to metrics files:
test/maximum.metrics
andtest/sora_cluster_metrics_enabled.metrics
: Thesora_cluster_node
metrics were updated to include thenode_type
attribute. [1] [2]Documentation update:
CHANGES.md
: The addition of thenode_type
attribute to thesora_cluster_node
metrics was documented.