New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: simplify solid playground #31

Merged

antfu merged 2 commits into shikijs:main from JLarky:patch-1

Oct 21, 2024

Contributor

JLarky commented Oct 19, 2024

This should not be introducing any changes, just a cleanup after looking at other implementations :)

I see quite a few attempts of making Solid version work were made fix: move options into it's own effect to fix toggle #30 fix: make toggling options re-render in playground (solid) #29
but I feel like they are making everything way more complicated than it needs to be :)

JLarky added 2 commits

October 19, 2024 14:16


          simplify solid playground

ba43300

This should not be introducing any changes, just a cleanup after looking at other implementations :)


          remove unnecessary optional chaining

e0e2cc0

JLarky mentioned this pull request

fix: move options into it's own effect to fix toggle #30

Closed

antfu changed the title ~~simplify solid playground~~ docs: simplify solid playground

antfu merged commit b6c7218 into shikijs:main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet