Refactored ReportSummary and also migrate to typescript #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidtohan
force-pushed
the
sidtohan/tsrefactor/attendance
branch
2 times, most recently
from
8c93750
to
8d25071
Compare
sidtohan
force-pushed
the
sidtohan/tsrefactor/attendance
branch
from
8d25071
to
ab4c027
Compare
|
@sagarkoshti1990 I've made the suggested changes, please have a look |
arajput
requested changes
Aug 2, 2022
packages/attendance/src/utils/functions/GetStudentsAttendance.ts
Outdated
Show resolved
Hide resolved
packages/attendance/src/utils/functions/GetStudentsAttendance.ts
Outdated
Show resolved
Hide resolved
…dule: * migrated ReportSummary to typescript * added some customhooks which may help in general use * added some more utilities
* now using the template literals for the title heading property in the design state
* fix the util function names to follow camelcasing * fix some issue regarding format date in Children component * removed some unnecessary code from the utils * fixed function names to better express their purpose
sidtohan
force-pushed
the
sidtohan/tsrefactor/attendance
branch
from
ab4c027
to
039825d
Compare
|
Ok @arajput I've made the suggested changes, please have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per suggestions, following a step by step approach for the migration and refactoring for the attendance module.
Changes
Made the following changes:
How to test
lerna run start --parallel --scope='{attendance,core,@shiksha/common-lib,students}'to fire up just the attendance module and its related dependencies.
Modified ReportSummary