Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fido2luks can't find Nitrokey 3A NFC #51

Open
intr-cx opened this issue Jan 22, 2023 · 2 comments
Open

fido2luks can't find Nitrokey 3A NFC #51

intr-cx opened this issue Jan 22, 2023 · 2 comments

Comments

@intr-cx
Copy link

intr-cx commented Jan 22, 2023

Hi,
Thank you for creating and maintaining fido2luks.

I've successfully used it with the Nitrokey FIDO2, however the Nitrokey 3A NFC - which supports fido2 - is not detected.
Using fido2luks connected returns nothing with exit code 1, and fido2luks credential hangs indefinitely.
My Rust knowledge is very limited, but I'd like to help get this resolved. I've tried running https://github.com/shimunn/ctap/blob/f982494d5158062b7ebb9f84cd04f28d2be36ce7/examples/hmac.rs but it panics at line 17 with 'No authenticator found'. However, testing the same device on something like https://webauthn.io/ works fine.
If more information is needed I'll do my best to provide it.

@robin-nitrokey
Copy link

robin-nitrokey commented Feb 14, 2023

I suspect that this is caused by a bug in the USB descriptor parsing in the ctap/ctap_hmac crate. See trussed-dev/usbd-ctaphid#1 (comment) for more information.

I’ve prepared a patch for the ctap and ctap_hmac crates that fixes device enumeration for my NK3CN. You can use the new list example to test it (cargo run --example list). I haven’t tested fido2luks with it, but this should at least let it detect the device.

ArdaXi/ctap#5
shimunn/ctap#8

@intr-cx
Copy link
Author

intr-cx commented Feb 15, 2023

Hi @robin-nitrokey

I've cloned and built your PR and ran the list example, and it indeed detects it!

savau added a commit to savau/disko that referenced this issue Apr 10, 2024
Allow for Nitrokey 3A NFC support via a forked fido2luks
See shimunn/fido2luks#51 for details.
savau added a commit to savau/disko that referenced this issue Apr 10, 2024
Allow for Nitrokey 3A NFC support via a forked fido2luks
See shimunn/fido2luks#51 for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants