Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Prune intermediate container images" proposal #226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add "Prune intermediate container images" proposal #226

wants to merge 1 commit into from

Conversation

HeavyWombat
Copy link
Contributor

Changes

Add "Prune intermediate container images" enhancement proposal.

/kind design

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 5, 2024
@openshift-ci openshift-ci bot added the kind/design Categorizes issue or PR as related to design. label Jul 5, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign saschaschwarze0 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SaschaSchwarze0
SaschaSchwarze0 reviewed Jul 8, 2024
View reviewed changes
ships/0039-prune-intermediate-container-images.md Outdated

## Alternatives

As touched briefly in the beginning, the alternative would be to rewrite the build in such a way that an additional intermediate container registry can be used. This additional registry doesn't necessarily have to be a temporary registry that is deployed in the build pod or along with the build, but could be a standalone container registry that needs to be configured and acts as a temporary location. However, this approach requires a significant more planning work and additional enhancement proposal to clarify the requirements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually, such an intermediate container registry would also allow to fully use vulnerability scanning for strategy-managed push with failOnFindings set to true. Today, we would not allow such a setting because we cannot prevent pushing to the destination if the strategy does it already.

@HeavyWombat
Add "Prune intermediate container images" proposal
20a3dc7 
Add "Prune intermediate container images" enhancement proposal.
@HeavyWombat HeavyWombat force-pushed the ship/prune-intermediate-container-images branch from 9321e0e to 20a3dc7 Compare September 6, 2024 10:07
@qu1queee qu1queee mentioned this pull request Nov 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee Awaiting requested review from qu1queee

@SaschaSchwarze0 SaschaSchwarze0 Awaiting requested review from SaschaSchwarze0

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/design Categorizes issue or PR as related to design. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Shipwright Overview
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeavyWombat @SaschaSchwarze0