Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update entities-via-attributes.md #1554

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Update entities-via-attributes.md #1554

merged 1 commit into from
Nov 13, 2024

Conversation

jrson83
Copy link
Contributor

@jrson83 jrson83 commented Nov 12, 2024

  • fix wrong indentation in code block
  • fix import statement of EntityCustomFieldsTrait

@jrson83
Update entities-via-attributes.md
92b0a2b 
- fix wrong indentation in code block
- fix import statement of `EntityCustomFieldsTrait`
@Isengo1989 Isengo1989 self-requested a review November 13, 2024 08:49
Isengo1989
Isengo1989 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR @jrson83 🥳

@Isengo1989 Isengo1989 merged commit 69266ed into shopware:main Nov 13, 2024
5 of 6 checks passed
@jrson83 jrson83 deleted the patch-2 branch November 13, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isengo1989 Isengo1989 Isengo1989 approved these changes

@mitelg mitelg mitelg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrson83 @mitelg @Isengo1989