Fix paged listing with emotion

[lacknere]

1. Why is this change necessary?

Because the product listing is not shown if the page parameter is defined and an emotion is shown.

2. What does this change do, exactly?

Remove the sPage parameter check when collecting devices with listing.

3. Describe each step to reproduce the issue or behaviour.

Create an emotion > assign it to a category with products > activate product listing > select "Category start page and listing" as visibility > go to the second page of the product listing > emotion is shown, product listing is not

4. Please link to the relevant issues (if any).

5. Which documentation changes (if any) need to be made because of this PR?

6. Checklist

• I have written tests and verified that they fail without my change
• I have squashed any insignificant commits
• This change has comments for package types, values, functions, and non-obvious lines of code
• I have read the contribution requirements and fulfil them.

[github-actions]

	Warnings
⚠️	The Pull Request doesn't contain any changes to the Upgrade file

[aragon999]

Mh, I always thought this is a feature and not a bug, i.e. that the emotion is only shown on the first page.

[mitelg]

this is indeed intentional and the if condition should not be simply removed.

what about an event where you are able to adjust if the method returns data or an empty array?

[lacknere]

Just to be clear, if I have an emotion with visibility "start page and listing" and the option "product listing" active, I would expect the emotion AND the product listing to show up when I click on the next page button of the pagination. That is not the case, which is why i thought this was a bug rather than intention.

[mitelg]

I guess, then the change is too general and will affected other settings and options as well.

we should find a more particular solution and make sure that other settings are not affected. (by writing or extending tests)

[mitelg]

hey @lacknere any progress here?

[lacknere]

@mitelg well, this turned out to work as expected with a clean shopware 5 setup. That was just a bug caused by css from the custom theme 🤦