Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume EEIs are power producers. #229

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Assume EEIs are power producers. #229

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e6bf9d
Assume EEIs are power producers.
DaleStan Feb 12, 2023
b18061a
Explain why some factorioTypes aren't calling ReadEnergySource.
DaleStan Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Yafc.Parser/Data/FactorioDataDeserializer_Entity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ private void DeserializeEntity(LuaTable table, ErrorCollector errorCollector) {
entity.size = table.Get("selection_box", out LuaTable? box) ? GetSize(box) : 3;

_ = table.Get("energy_source", out LuaTable? energySource);
if (factorioType != "generator" && factorioType != "solar-panel" && factorioType != "accumulator" && factorioType != "burner-generator" && factorioType != "offshore-pump" && energySource != null) {
if (factorioType != "generator" && factorioType != "solar-panel" && factorioType != "accumulator" && factorioType != "burner-generator" && factorioType != "offshore-pump" && factorioType != "electric-energy-interface" && energySource != null) {
shpaass marked this conversation as resolved.
Show resolved Hide resolved
ReadEnergySource(energySource, entity, defaultDrain);
}

Expand Down
2 changes: 2 additions & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ Version
Date:
Bugfixes:
- Refuse to accept negative numbers in several places where they don't make sense.
- Handle electric energy interfaces better (e.g. pY's fish turbines, Nullius's wind turbines) when used to
generate power.
Internal changes:
- Refactor a lot of the drawing code to increase both UI consistency and consistency in being able to pass
options to methods that should accept them.
Expand Down