fix: delete pending pod when workflow terminated

Co-authored-by: shuangkun <[email protected]> Co-authored-by: zjgemi <[email protected]> Signed-off-by: shuangkun <[email protected]>
shuangkun · Nov 21, 2023 · ebb458f · ebb458f
1 parent 222d53c
commit ebb458f
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/workflow/controller/controller.go b/workflow/controller/controller.go
@@ -512,7 +512,10 @@ func (wfc *WorkflowController) processNextPodCleanupItem(ctx context.Context) bo
 		pods := wfc.kubeclientset.CoreV1().Pods(namespace)
 		switch action {
 		case terminateContainers:
-			if terminationGracePeriod, err := wfc.signalContainers(namespace, podName, syscall.SIGTERM); err != nil {
+			pod, err := wfc.getPod(namespace, podName)
+			if err == nil && pod != nil && pod.Status.Phase == "Pending" {
+				wfc.queuePodForCleanup(pod.Namespace, pod.Name, deletePod)
+			} else if terminationGracePeriod, err := wfc.signalContainers(namespace, podName, syscall.SIGTERM); err != nil {
 				return err
 			} else if terminationGracePeriod > 0 {
 				wfc.queuePodForCleanupAfter(namespace, podName, killContainers, terminationGracePeriod)