Wrong way of using of TaskCreationOptions.LongRunning

shubhamranjan · Aug 4, 2024 · 12adafa · 12adafa
1 parent 72315fe
commit 12adafa
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/dotnet-etcd/leaseClient.cs b/dotnet-etcd/leaseClient.cs
@@ -95,6 +95,7 @@ public Task LeaseKeepAlive(CancellationTokenSource cancellationTokenSource, long
             }
 
             CancellationToken cancellationToken = cancellationTokenSource.Token;
+            int communicationTimeoutInMilliseconds = communicationTimeout ?? keepAliveTimeout / 2;
 
             async ValueTask WriteAsync(AsyncDuplexStreamingCall<LeaseKeepAliveRequest, LeaseKeepAliveResponse> leaser, LeaseKeepAliveRequest request, int timeoutInMilliseconds, CancellationToken cancellationToken)
             {
@@ -125,9 +126,8 @@ AsyncDuplexStreamingCall<LeaseKeepAliveRequest, LeaseKeepAliveResponse> LeaseKee
                 return connection.LeaseClient.LeaseKeepAlive(headers, deadline, cancellationTokenSource.Token);
             }
 
-            async Task KeepAliveAsync(object state)
+            async Task KeepAliveAsync()
             {
-                int communicationTimeoutInMilliseconds = communicationTimeout ?? keepAliveTimeout / 2;
                 LeaseKeepAliveRequest request = new()
                 {
                     ID = leaseId,
@@ -210,13 +210,7 @@ await cancellationTokenSource.CancelAsync()
                 }
             }
 
-            return Task.Factory.StartNew(
-                KeepAliveAsync,
-                null,
-                cancellationToken,
-                TaskCreationOptions.LongRunning,
-                TaskScheduler.Current)
-                .Unwrap();
+            return Task.Run(KeepAliveAsync, cancellationToken);
         });
 
         /// <summary>