feat(alloy): Migrate pool lens to use Alloy #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes significant changes to the build process and project configuration. The changes include updating the .gitignore file to include Cargo.lock, adding the INFURA_API_KEY environmental variable to Rust workflow, and modifying commands in the Rust and Github workflows. Refactoring also involved changing the project's metadata in Cargo.toml and altering various settings in rustfmt.toml and package.json. Lastly, the Github workflow for npm_publish was removed.
This commit migrates the pool lens functions to use Alloy for making calls and decoding results. All calls to the `Middleware` trait and its `client` have been replaced with the Alloy `Provider` trait and its `provider`. The functions now return an `anyhow::Result` instead of a `ContractError`, providing a more generic error handling approach. The diff also includes commenting out `position_lens` and `storage_lens`. Further testing and validation are required to ensure correct information retrieval and error management post-migration.
The commit removes the formatting check step from the GitHub Actions workflow for Rust. This step was unnecessary and was causing redundancy in the workflow. The focus is now solely on linting checks, making the process more streamlined and efficient.
malik672
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.