feat(alloy): Refactor position_lens for Alloy #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unrelated test setup in pool_lens.rs has been refactored and moved to a separate module, tests.rs to improve modularity. Also, the package version has been updated in Cargo.toml and an additional module, position_lens, has been included in the project's public API (lib.rs).
This commit involves a significant refactoring of the `position_lens.rs` file to adapt it for Alloy. The change includes updating function parameters to fit Alloy's needs, adjusting dependency imports, and modifying variable names for consistency. The changes are extensive but primarily revolve around updating the function parameters and the data types used. The tests have been updated to reflect the changes too.
malik672
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.