Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Misc #3

wants to merge 1 commit into from

Conversation

peterthomassen
Copy link

No description provided.

vttale
vttale reviewed Mar 17, 2024
View reviewed changes
Copy link

@vttale vttale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUST vs SHOULD for NSEC/RRSIG at empty owner name

draft-ietf-dnsop-compact-denial-of-existence.xml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason behind changing MUST to SHOULD here and in the next difference, about NSEC/RRSIG at an owner name that has no other records?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current text says "MUST", which is an "absolute requirement". Right after, it has an exception. I think this is better expressed via "SHOULD" followed by an explanation of "valid reasons in particular circumstances to ignore" it. (Quotes from RFC 2119)

Also, if we think there's no interoperability problem in ignoring the MUST, then I think there's limited justification for requiring it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, I was only looking at the diff and not the full context. The new context definitely makes SHOULD more warranted.

@shuque shuque force-pushed the main branch 2 times, most recently from d9ebec0 to e5da144 Compare January 7, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vttale vttale vttale left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterthomassen @vttale