move constants to separate file

siarheivesialou · Dec 28, 2023 · 554759a · 554759a
1 parent 8a1730b
commit 554759a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/ydb/core/kafka_proxy/actors/kafka_create_topics_actor.cpp b/ydb/core/kafka_proxy/actors/kafka_create_topics_actor.cpp
@@ -4,10 +4,10 @@
 
 #include <ydb/services/lib/actors/pq_schema_actor.h>
 
-namespace NKafka {
+#include <ydb/core/kafka_proxy/kafka_constants.h>
+
 
-static const TString RETENTION_MS_CONFIG_NAME = "retention.ms";
-static const TString RETENTION_BYTES_CONFIG_NAME = "retention.bytes";
+namespace NKafka {
 
 class TKafkaCreateTopicRequest : public NKikimr::NGRpcService::IRequestOpCtx {
 public:
@@ -405,9 +405,9 @@ void TKafkaCreateTopicsActor::Bootstrap(const NActors::TActorContext& ctx) {
         auto processConfig = [&topic, &retentionMs, &retentionBytes, &parseRetention]() -> bool { 
             for (auto& config : topic.Configs) {
                 bool result = true;
-                if (config.Name.value() == "retention.bytes") {
+                if (config.Name.value() == RETENTION_BYTES_CONFIG_NAME) {
                     result = parseRetention(config, retentionBytes);
-                } else if (config.Name.value() == "retention.ms") {
+                } else if (config.Name.value() == RETENTION_MS_CONFIG_NAME) {
                     result = parseRetention(config, retentionMs);
                 }
                 if (!result) {

diff --git a/ydb/core/kafka_proxy/kafka_constants.h b/ydb/core/kafka_proxy/kafka_constants.h
@@ -0,0 +1,8 @@
+#pragma once
+
+#include <util/generic/string.h>
+
+namespace NKafka {
+    static const TString RETENTION_MS_CONFIG_NAME = "retention.ms";
+    static const TString RETENTION_BYTES_CONFIG_NAME = "retention.bytes";
+}
diff --git a/ydb/core/kafka_proxy/ya.make b/ydb/core/kafka_proxy/ya.make
@@ -18,6 +18,7 @@ SRCS(
     actors/kafka_create_topics_actor.cpp
     kafka_connection.cpp
     kafka_connection.h
+    kafka_constants.h
     kafka_listener.h
     kafka.h
     kafka_log.h