Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of the issue when removal of the last event in the InMemory table… #1844

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ydidukh
Copy link

@ydidukh ydidukh commented Sep 6, 2024

Purpose

Resolves issue 1822 - Removal of the last stored event in the InMemory table disrupts the references chain, subsequently causing improper behaviour within the InMemory table. Any future inserts are erroneously appended to the removed event, leading to unexpected and undesired outcomes.

Goals

Fix the logic of the remove method in the SnapshotableStreamEventQueue class to gracefully handle the removal of the last item. Reset the last variable to point to the previous item if the item being removed is the last one.

Security checks

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants