Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified getting the asset state as string, removed unused helpers #156

Open
wants to merge 1 commit into
base: Houdini18.5-4.26
Choose a base branch
from

Conversation

moppius
Copy link

@moppius moppius commented Jul 8, 2021

EnumToString was failing to compile on Linux, and these helper functions seem surplus to requirements - they were only used in one place, and it seems neater just to call UEnum::GetValueAsString directly.

This is the Linux build error we hit:

/build/ue4/Engine/Plugins/Runtime/HoudiniEngine/Source/HoudiniEngineRuntime/Private/HoudiniEngineRuntimeUtils.h:173:18: error: no matching function for call to 'FindObject'
                        UEnum* Enum = FindObject<UEnum>(ANY_PACKAGE, *EnumName);
                                      ^~~~~~~~~~~~~~~~~
/build/ue4/Engine/Source/Runtime/CoreUObject/Public/UObject/UObjectGlobals.h:1255:11: note: candidate function template not viable: cannot convert argument of incomplete type 'UPackage *' to 'UObject *' for 1st argument

EnumToString was failing to compile on Linux, and is surplus to requirements now
@moppius
Copy link
Author

moppius commented Aug 11, 2021

The Linux compile issue seems to be fixed in 2.0.3 somehow, although I notice that the original methods are still there, and still seem to be redundant (why not just use UEnum::GetValueAsString inline?).

Feel free to close this PR if you don't want the change 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant