Fix version upgrade for ND_normalmap_vector2 (AcademySoftwareFoundati…

…on#2022)

The upgrade code for the normalmap node was indiscriminately renaming all node definitions to "ND_normalmap_float". This included "ND_normalmap_vecto2" nodes, whose nodedef should not be renamed.

This commit fixes that, limiting the renaming only to "ND_normalmap", based on the type of the "scale" input, which is the only differentiating factor between the two definitions.

source/MaterialXCore/Version.cpp

@@ -1317,7 +1317,13 @@ void Document::upgradeVersion()
             else if (nodeCategory == "normalmap")
             {
                 // ND_normalmap was renamed to ND_normalmap_float
-                node->setNodeDefString("ND_normalmap_float");
+                NodeDefPtr nodeDef = getShaderNodeDef(node);
+                InputPtr scaleInput = node->getInput("scale");
+                if ((nodeDef && nodeDef->getName() == "ND_normalmap") ||
+                    (scaleInput && scaleInput->getType() == "float"))
+                {
+                    node->setNodeDefString("ND_normalmap_float");
+                }
 
                 node->removeInput("space");