Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: csr approval controller #192

Merged
merged 1 commit into from
Aug 28, 2024
Merged

refactor: csr approval controller #192

merged 1 commit into from
Aug 28, 2024

Conversation

sergelogvinov
Copy link
Collaborator

Pull Request

What? (description)

Move CSR Approval to separate controller.

Why? (reasoning)

close #178

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you linted your code (make lint)
  • you linted your code (make unit)

See make help for a description of the available targets.

@sergelogvinov sergelogvinov force-pushed the csr-controller branch 2 times, most recently from 69b8976 to 23531e2 Compare August 28, 2024 14:08
@sergelogvinov
refactor: csr approval controller
09a5b9e 
Move CSR Approval to separate controller.

Signed-off-by: Serge Logvinov <[email protected]>
@sergelogvinov
Copy link
Collaborator Author

/m

@talos-bot talos-bot merged commit 09a5b9e into siderolabs:main Aug 28, 2024
4 checks passed
@sergelogvinov sergelogvinov deleted the csr-controller branch August 28, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frezbo frezbo frezbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Node certificate signing request approval to separate controller
3 participants
@sergelogvinov @frezbo @talos-bot