Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make kube-apiserver endpoint configurable #202

Conversation

sanderterschure
Copy link
Contributor

@sanderterschure sanderterschure commented Oct 1, 2024

Pull Request

What? (description)

In the current helm chart there is no option to configure the Kubernetes API endpoint when deploying the CCM as a daemonset. This PR adds the option to make the kube-apiserver endpoint configurable.

...
daemonSet:
  enabled: true
  k8s:
    serviceHost: 10.0.0.1
    servicePort: 443
...

Why? (reasoning)

In my setup we are running the kube-apiserver on a different port because of firewall limitations. Since this is not configurable the deployed will fail with the following logs:

0930 13:21:31.971223       1 serving.go:386] Generated self-signed cert in-memory
I0930 13:21:32.407675       1 serving.go:386] Generated self-signed cert in-memory
W0930 13:21:32.407727       1 client_config.go:659] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
unable to load configmap based request-header-client-ca-file: Get "https://10.60.0.11:6443/api/v1/namespaces/kube-system/configmaps/extension-apiserver-authentication": dial tcp 10.60.0.11:6443: connect: connection refused
E0930 13:21:32.776521       1 run.go:72] "command failed" err="unable to load configmap based request-header-client-ca-file: Get \"[https://10.60.0.11:6443/api/v1/namespaces/kube-system/configmaps/extension-apiserver-authentication\](https://10.60.0.11:6443/api/v1/namespaces/kube-system/configmaps/extension-apiserver-authentication/)": dial tcp 10.60.0.11:6443: connect: connection refused"

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you linted your code (make lint)
  • you linted your code (make unit)

See make help for a description of the available targets.

@sanderterschure sanderterschure force-pushed the feat/make-kubernetes-api-configurable branch from 5d5acdd to 87a391a Compare October 1, 2024 11:47
@sanderterschure sanderterschure force-pushed the feat/make-kubernetes-api-configurable branch from 9d649b0 to 081f2d8 Compare October 2, 2024 06:38
@sergelogvinov
Copy link
Collaborator

sergelogvinov commented Oct 2, 2024

Hi, sorry for delay.

Can you:

  • use low case on commit message
  • add commit body
  • DSO (sign-off) commit (git commit -s)
  • and make one commit (squash commits) in one

And we can merge it! 👍

Add helm values to configure kube-apiserver endpoint when using type: DaemonSet

Signed-off-by: Sander ter Schure <[email protected]>
@sanderterschure sanderterschure force-pushed the feat/make-kubernetes-api-configurable branch from 081f2d8 to 628a7b7 Compare October 3, 2024 14:13
@sergelogvinov
Copy link
Collaborator

/m

@sergelogvinov
Copy link
Collaborator

/m

@talos-bot talos-bot merged commit 628a7b7 into siderolabs:main Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants