feat: generate iqn and nqn files. #10162
Merged
+248
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
force-pushed
the
feat/iqn-nqn
branch
2 times, most recently
from
2109b79 to
d02173d
Compare
DmitriyMV
approved these changes
Jan 20, 2025
smira
reviewed
Jan 20, 2025
smira
approved these changes
Jan 20, 2025
Generate deterministic IQN and NQN files based on `machine-id`. Fixes: siderolabs#10009 Signed-off-by: Noel Georgi <[email protected]>
|
/m |
frezbo
added a commit
to frezbo/extensions
that referenced
this pull request
Jan 20, 2025
* `tgtd` is only needed if exposing `iSCSI` targets from the host, not needed when using as a client. * Use `/system/etc` as writable homedir for open-iscsi * Drop `isns` since we never ran `isns` daemon * Drop `iscsid-wrapper` since Talos now manages `iqn`, ref: siderolabs/talos#10162 Signed-off-by: Noel Georgi <[email protected]>
frezbo
added a commit
to frezbo/extensions
that referenced
this pull request
Jan 20, 2025
* `tgtd` is only needed if exposing `iSCSI` targets from the host, not needed when using as a client. * Drop `isns` since we never ran `isns` daemon * Drop `iscsid-wrapper` since Talos now manages `iqn`, ref: siderolabs/talos#10162 Signed-off-by: Noel Georgi <[email protected]>
frezbo
added a commit
to frezbo/extensions
that referenced
this pull request
Jan 20, 2025
* `tgtd` is only needed if exposing `iSCSI` targets from the host, not needed when using as a client. * Drop `isns` since we never ran `isns` daemon * Drop `iscsid-wrapper` since Talos now manages `iqn`, ref: siderolabs/talos#10162 Signed-off-by: Noel Georgi <[email protected]>
frezbo
added a commit
to frezbo/extensions
that referenced
this pull request
Jan 20, 2025
* `tgtd` is only needed if exposing `iSCSI` targets from the host, not needed when using as a client. * Drop `isns` since we never ran `isns` daemon * Drop `iscsid-wrapper` since Talos now manages `iqn`, ref: siderolabs/talos#10162 Signed-off-by: Noel Georgi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate deterministic IQN and NQN files based on
machine-id.Fixes: #10009