Enable back Infection, fix new mutants

.github/workflows/ci.yaml

@@ -57,10 +57,10 @@ jobs:
         shell: bash
         run: make tests
 
-#      - name: Run Infection for touched lines
-#        shell: bash
-#        if: github.event_name == 'pull_request'
-#        run: |
-#          git fetch origin $GITHUB_BASE_REF
-#          vendor/bin/infection --threads=max --only-covered --show-mutations --min-covered-msi=100 --git-diff-lines --git-diff-base=origin/$GITHUB_BASE_REF --ignore-msi-with-no-mutations
+      - name: Run Infection for touched lines
+        shell: bash
+        if: github.event_name == 'pull_request'
+        run: |
+          git fetch origin $GITHUB_BASE_REF
+          vendor/bin/infection --threads=max --only-covered --show-mutations --min-covered-msi=100 --git-diff-lines --git-diff-base=origin/$GITHUB_BASE_REF --ignore-msi-with-no-mutations
 

composer.json

@@ -27,6 +27,7 @@
     },
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^3.4",
+        "infection/infection": "^0.28.0",
         "phpunit/phpunit": "^10.1"
     },
     "autoload": {

infection.json5

@@ -11,6 +11,12 @@
             "ignore": [
                 "Sid\\PHPStan\\Rules\\MagicNumber\\AbstractMagicNumberRule::isNumericString"
             ]
+        },
+        "FalseValue": {
+            "ignore": [
+                // because in current tests Rule is always created with $ignoreNumericStrings=false
+                "Sid\\PHPStan\\Rules\\MagicNumber\\AbstractMagicNumberRule::__construct"
+            ]
         }
     }
 }

src/Rules/MagicNumber/NoMagicNumberInArithmeticOperatorRule.php

@@ -19,11 +19,11 @@ final class NoMagicNumberInArithmeticOperatorRule extends AbstractMagicNumberRul
 
     public function getNodeType(): string
     {
-        return Node\Expr\BinaryOp::class;
+        return BinaryOp::class;
     }
 
     /**
-     * @param Node\Expr\BinaryOp $node
+     * @param BinaryOp $node
      */
     public function processNode(Node $node, Scope $scope): array
     {

tests/Rules/MagicNumber/NoMagicNumberInMatchCaseRuleTest.php

@@ -36,7 +36,11 @@ public function test_rule(): void
                 ],
                 [
                     NoMagicNumberInMatchRule::MATCH_ARM_COND_MESSAGE,
-                    8,
+                    9,
+                ],
+                [
+                    NoMagicNumberInMatchRule::MATCH_ARM_COND_MESSAGE,
+                    9,
                 ],
             ]
         );

tests/Rules/MagicNumber/NoMagicNumberInSwitchCaseRuleTest.php

@@ -24,11 +24,14 @@ public function test_rule(): void
                 ],
                 [
                     NoMagicNumberInSwitchCaseRule::ERROR_MESSAGE,
-                    6,
+                    8,
+                ],                [
+                    NoMagicNumberInSwitchCaseRule::ERROR_MESSAGE,
+                    10,
                 ],
                 [
                     NoMagicNumberInSwitchCaseRule::ERROR_CONDITION_MESSAGE,
-                    11,
+                    15,
                 ],
             ]
         );

tests/Rules/MagicNumber/data/match-case.php

@@ -5,7 +5,8 @@
 match (3) {
     1 => 'Hi',
     2, 4 => 'There',
-    '1', 5 => 'magic number after string',
+    'string in the middle', '5' => 'There',
+    '1', 6 => 'magic number after string',
     default => throw new LogicException(),
     0 => 'Hello',
 };

tests/Rules/MagicNumber/data/switch-case.php

@@ -3,6 +3,10 @@
 switch (100) {
     case 5:
         break;
+    case 'string in the middle':
+        break;
+    case 6:
+        break;
     case '10':
         break;
 }