Improve card and push-card components #1621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 06597db The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nuke-ellington
requested changes
Jan 7, 2025
test(push-card): move overflow vrt to separate describe test(card): move overflow vrt to separate describe test(push-card): add vrt snapshots test(card): add vrt snapshots test(push-card): add vrt for text overflow test(card): add vrt for text overflow
nuke-ellington
previously approved these changes
Jan 13, 2025
nuke-ellington
requested changes
Jan 13, 2025
| } | ||
|
|
||
| .card-content-wrapper { | ||
| padding: 1rem; |
There was a problem hiding this comment.
In case ix-card-content was is not used this will create padding that was not there before.
Resulting VRT snapshot:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 What is the current behavior?
GitHub Issue Number: IX-529
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs)pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support