-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve card and push-card components #1621
Open
AndreasBerliner
wants to merge
13
commits into
main
Choose a base branch
from
card-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ab48fa0
fix(card): add pointer cursor, overflow hidden
AndreasBerliner cc7b33e
fix(push-card): cursor styling
AndreasBerliner cd0d550
Merge branch 'main' into card-improvements
AndreasBerliner 61ae113
Merge branch 'main' into card-improvements
AndreasBerliner 500fbb9
Merge branch 'main' into card-improvements
AndreasBerliner 91cab43
Create strong-bags-run.md
nuke-ellington 0d16389
test(card): fix snapshots for overflow vrt
AndreasBerliner dd750b0
fix: include padding in overflow
matthiashader 2c779b9
fix: behavior with card-content
matthiashader 8d38537
fix: show-more card and vrts
matthiashader 1258bb6
Merge branch 'main' into card-improvements
matthiashader 06597db
fix: adapt code to figma
matthiashader bebcb9e
fix: update push-card vrts
matthiashader File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@siemens/ix": patch | ||
--- | ||
|
||
Set correct cursors and handle overflow for **ix-card** and **ix-push-card**. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,6 @@ | |
flex-direction: column; | ||
align-items: flex-start; | ||
gap: 0.5rem; | ||
padding: 1rem; | ||
height: 100%; | ||
overflow: hidden; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+27 KB
...overflow-should-hide-overflowing-text-1-chromium---theme-classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+27.3 KB
...verflow-should-hide-overflowing-text-1-chromium---theme-classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
<!-- | ||
SPDX-FileCopyrightText: 2025 Siemens AG | ||
|
||
SPDX-License-Identifier: MIT | ||
--> | ||
|
||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<meta | ||
name="viewport" | ||
content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=5.0" | ||
/> | ||
<title>Stencil Component Starter</title> | ||
<style> | ||
ix-card { | ||
margin: 1rem; | ||
height: 12rem; | ||
width: 12rem; | ||
} | ||
</style> | ||
</head> | ||
<body> | ||
<ix-card> | ||
<ix-card-content> | ||
<ix-typography> | ||
This is an example text for testing the overflow behavior. This is an | ||
example text for testing the overflow behavior. This is an example | ||
text for testing the overflow behavior. This is an example text for | ||
testing the overflow behavior. This is an example text for testing the | ||
overflow behavior. This is an example text for testing the overflow | ||
behavior. | ||
</ix-typography> | ||
</ix-card-content> | ||
</ix-card> | ||
<script src="http://127.0.0.1:8080/scripts/e2e/load-e2e-runtime.js"></script> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
<!-- | ||
SPDX-FileCopyrightText: 2025 Siemens AG | ||
|
||
SPDX-License-Identifier: MIT | ||
--> | ||
|
||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<meta | ||
name="viewport" | ||
content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=5.0" | ||
/> | ||
<title>Stencil Component Starter</title> | ||
<style> | ||
ix-push-card { | ||
margin: 1rem; | ||
} | ||
</style> | ||
</head> | ||
<body> | ||
<ix-push-card | ||
icon="bulb" | ||
notification="99" | ||
heading="This is an example text for testing the overflow behavior." | ||
subheading="This is an example text for testing the overflow behavior. This is an | ||
example text for testing the overflow behavior. This is an example | ||
text for testing the overflow behavior. This is an example text for | ||
testing the overflow behavior. This is an example text for testing the | ||
overflow behavior. This is an example text for testing the overflow | ||
behavior." | ||
> | ||
</ix-push-card> | ||
<script src="http://127.0.0.1:8080/scripts/e2e/load-e2e-runtime.js"></script> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+33.9 KB
...overflow-should-hide-overflowing-text-1-chromium---theme-classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+34.1 KB
...verflow-should-hide-overflowing-text-1-chromium---theme-classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case ix-card-content was is not used this will create padding that was not there before.
Resulting VRT snapshot: