Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect button properties to 'date-dropdown' and 'expanded-search' #1635

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

reflect button properties to 'date-dropdown' and 'expanded-search' #1635

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f8f1772
feat: reflect button properties to date-dropdown and expanded-search
matthiashader Jan 8, 2025
f0b0f2d
chore: changeset
matthiashader Jan 8, 2025
7337b8a
fix: strict typing
matthiashader Jan 8, 2025
33e655d
feat: added interface and implemented it in date-dropdown and expadin…
matthiashader Jan 8, 2025
aadefbb
fix: update figma url
matthiashader Jan 8, 2025
8b19d11
fix: adapt review comments
matthiashader Jan 9, 2025
1e9688d
fix: review comments
matthiashader Jan 13, 2025
851afd7
Merge branch 'main' into feat/2256-datedropdown
matthiashader Jan 15, 2025
e939d3f
fix: update vrt for ubuntu noble
matthiashader Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/small-pants-think.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@siemens/ix-angular': minor
'@siemens/ix': minor
'@siemens/ix-vue': minor
---

reflect button properties to 'date-dropdown' and 'expanded-search'
nuke-ellington marked this conversation as resolved.
Show resolved Hide resolved
8 changes: 4 additions & 4 deletions packages/angular/src/components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,15 +568,15 @@ export declare interface IxCustomField extends Components.IxCustomField {}


@ProxyCmp({
inputs: ['customRangeAllowed', 'dateRangeId', 'dateRangeOptions', 'disabled', 'format', 'from', 'i18nCustomItem', 'i18nDone', 'i18nNoRange', 'locale', 'maxDate', 'minDate', 'range', 'to', 'weekStartIndex'],
inputs: ['buttonGhost', 'buttonLoading', 'buttonOutline', 'buttonVariant', 'customRangeAllowed', 'dateRangeId', 'dateRangeOptions', 'disabled', 'format', 'from', 'i18nCustomItem', 'i18nDone', 'i18nNoRange', 'locale', 'maxDate', 'minDate', 'range', 'to', 'weekStartIndex'],
methods: ['getDateRange']
})
@Component({
selector: 'ix-date-dropdown',
changeDetection: ChangeDetectionStrategy.OnPush,
template: '<ng-content></ng-content>',
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
inputs: ['customRangeAllowed', 'dateRangeId', 'dateRangeOptions', 'disabled', 'format', 'from', 'i18nCustomItem', 'i18nDone', 'i18nNoRange', 'locale', 'maxDate', 'minDate', 'range', 'to', 'weekStartIndex'],
inputs: ['buttonGhost', 'buttonLoading', 'buttonOutline', 'buttonVariant', 'customRangeAllowed', 'dateRangeId', 'dateRangeOptions', 'disabled', 'format', 'from', 'i18nCustomItem', 'i18nDone', 'i18nNoRange', 'locale', 'maxDate', 'minDate', 'range', 'to', 'weekStartIndex'],
})
export class IxDateDropdown {
protected el: HTMLElement;
Expand Down Expand Up @@ -976,14 +976,14 @@ export declare interface IxEventListItem extends Components.IxEventListItem {


@ProxyCmp({
inputs: ['fullWidth', 'icon', 'placeholder', 'value']
inputs: ['buttonGhost', 'buttonLoading', 'buttonOutline', 'buttonVariant', 'fullWidth', 'icon', 'placeholder', 'value']
})
@Component({
selector: 'ix-expanding-search',
changeDetection: ChangeDetectionStrategy.OnPush,
template: '<ng-content></ng-content>',
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
inputs: ['fullWidth', 'icon', 'placeholder', 'value'],
inputs: ['buttonGhost', 'buttonLoading', 'buttonOutline', 'buttonVariant', 'fullWidth', 'icon', 'placeholder', 'value'],
})
export class IxExpandingSearch {
protected el: HTMLElement;
Expand Down
206 changes: 206 additions & 0 deletions packages/core/component-doc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4036,6 +4036,109 @@
]
},
"props": [
{
"name": "buttonGhost",
"type": "boolean",
"complexType": {
"original": "boolean",
"resolved": "boolean",
"references": {}
},
"mutable": false,
"attr": "button-ghost",
"reflectToAttr": false,
"docs": "Button with no background or outline",
"docsTags": [],
"default": "false",
"values": [
{
"type": "boolean"
}
],
"optional": false,
"required": false
},
{
"name": "buttonLoading",
"type": "boolean",
"complexType": {
"original": "boolean",
"resolved": "boolean",
"references": {}
},
"mutable": false,
"attr": "button-loading",
"reflectToAttr": false,
"docs": "Loading button",
"docsTags": [],
"default": "false",
"values": [
{
"type": "boolean"
}
],
"optional": false,
"required": false
},
{
"name": "buttonOutline",
"type": "boolean",
"complexType": {
"original": "boolean",
"resolved": "boolean",
"references": {}
},
"mutable": false,
"attr": "button-outline",
"reflectToAttr": false,
"docs": "Outline button",
"docsTags": [],
"default": "false",
"values": [
{
"type": "boolean"
}
],
"optional": false,
"required": false
},
{
"name": "buttonVariant",
"type": "\"danger\" | \"primary\" | \"secondary\"",
"complexType": {
"original": "ButtonVariant",
"resolved": "\"danger\" | \"primary\" | \"secondary\"",
"references": {
"ButtonVariant": {
"location": "import",
"path": "../button/button",
"id": "src/components/button/button.tsx::ButtonVariant"
}
}
},
"mutable": false,
"attr": "button-variant",
"reflectToAttr": false,
"docs": "button variant",
"docsTags": [],
"default": "'primary'",
"values": [
{
"value": "danger",
"type": "string"
},
{
"value": "primary",
"type": "string"
},
{
"value": "secondary",
"type": "string"
}
],
"optional": false,
"required": false
},
{
"name": "customRangeAllowed",
"type": "boolean",
Expand Down Expand Up @@ -7822,6 +7925,109 @@
]
},
"props": [
{
"name": "buttonGhost",
"type": "boolean",
"complexType": {
"original": "boolean",
"resolved": "boolean",
"references": {}
},
"mutable": false,
"attr": "button-ghost",
"reflectToAttr": false,
"docs": "Button with no background or outline",
"docsTags": [],
"default": "true",
"values": [
{
"type": "boolean"
}
],
"optional": false,
"required": false
},
{
"name": "buttonLoading",
"type": "boolean",
"complexType": {
"original": "boolean",
"resolved": "boolean",
"references": {}
},
"mutable": false,
"attr": "button-loading",
"reflectToAttr": false,
"docs": "Loading button",
"docsTags": [],
"default": "false",
"values": [
{
"type": "boolean"
}
],
"optional": false,
"required": false
},
{
"name": "buttonOutline",
"type": "boolean",
"complexType": {
"original": "boolean",
"resolved": "boolean",
"references": {}
},
"mutable": false,
"attr": "button-outline",
"reflectToAttr": false,
"docs": "Outline button",
"docsTags": [],
"default": "false",
"values": [
{
"type": "boolean"
}
],
"optional": false,
"required": false
},
{
"name": "buttonVariant",
"type": "\"danger\" | \"primary\" | \"secondary\"",
"complexType": {
"original": "ButtonVariant",
"resolved": "\"danger\" | \"primary\" | \"secondary\"",
"references": {
"ButtonVariant": {
"location": "import",
"path": "../button/button",
"id": "src/components/button/button.tsx::ButtonVariant"
}
}
},
"mutable": false,
"attr": "button-variant",
"reflectToAttr": false,
"docs": "button variant",
"docsTags": [],
"default": "'primary'",
"values": [
{
"value": "danger",
"type": "string"
},
{
"value": "primary",
"type": "string"
},
{
"value": "secondary",
"type": "string"
}
],
"optional": false,
"required": false
},
{
"name": "fullWidth",
"type": "boolean",
Expand Down
68 changes: 66 additions & 2 deletions packages/core/src/components.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { InputState } from "./components/category-filter/input-state";
import { ColumnSize } from "./components/col/col";
import { ContentHeaderVariant } from "./components/content-header/content-header";
import { CssGridTemplateType } from "./components/css-grid/css-grid";
import { ButtonVariant as ButtonVariant1 } from "./components/button/button";
import { DateDropdownOption, DateRangeChangeEvent } from "./components/date-dropdown/date-dropdown";
import { DateInputValidityState } from "./components/date-input/date-input";
import { DateTimeCardCorners } from "./components/date-time-card/date-time-card";
Expand All @@ -33,7 +34,6 @@ import { EmptyStateLayout } from "./components/empty-state/empty-state";
import { MakeRef } from "./components/utils/make-ref";
import { FlipTileState } from "./components/flip-tile/flip-tile-state";
import { IconButtonVariant } from "./components/icon-button/icon-button";
import { ButtonVariant as ButtonVariant1 } from "./components/button/button";
import { KeyValueLabelPosition } from "./components/key-value/key-value";
import { CustomCloseEvent, CustomLabelChangeEvent } from "./components/utils/menu-tabs/menu-tabs-utils";
import { IxModalSize } from "./components/modal/modal";
Expand Down Expand Up @@ -65,6 +65,7 @@ export { InputState } from "./components/category-filter/input-state";
export { ColumnSize } from "./components/col/col";
export { ContentHeaderVariant } from "./components/content-header/content-header";
export { CssGridTemplateType } from "./components/css-grid/css-grid";
export { ButtonVariant as ButtonVariant1 } from "./components/button/button";
export { DateDropdownOption, DateRangeChangeEvent } from "./components/date-dropdown/date-dropdown";
export { DateInputValidityState } from "./components/date-input/date-input";
export { DateTimeCardCorners } from "./components/date-time-card/date-time-card";
Expand All @@ -79,7 +80,6 @@ export { EmptyStateLayout } from "./components/empty-state/empty-state";
export { MakeRef } from "./components/utils/make-ref";
export { FlipTileState } from "./components/flip-tile/flip-tile-state";
export { IconButtonVariant } from "./components/icon-button/icon-button";
export { ButtonVariant as ButtonVariant1 } from "./components/button/button";
export { KeyValueLabelPosition } from "./components/key-value/key-value";
export { CustomCloseEvent, CustomLabelChangeEvent } from "./components/utils/menu-tabs/menu-tabs-utils";
export { IxModalSize } from "./components/modal/modal";
Expand Down Expand Up @@ -651,6 +651,22 @@ export namespace Components {
* @since 2.1.0
*/
interface IxDateDropdown {
/**
* Button with no background or outline
*/
"buttonGhost": boolean;
/**
* Loading button
*/
"buttonLoading": boolean;
/**
* Outline button
*/
"buttonOutline": boolean;
/**
* button variant
*/
"buttonVariant": ButtonVariant1;
/**
* Controls whether the user is allowed to pick custom date ranges in the component. When set to 'true', the user can select a custom date range using the date picker. When set to 'false', only predefined time date ranges are available for selection.
*/
Expand Down Expand Up @@ -1217,6 +1233,22 @@ export namespace Components {
"selected": boolean;
}
interface IxExpandingSearch {
/**
* Button with no background or outline
*/
"buttonGhost": boolean;
/**
* Loading button
*/
"buttonLoading": boolean;
/**
* Outline button
*/
"buttonOutline": boolean;
/**
* button variant
*/
"buttonVariant": ButtonVariant1;
/**
* If true the search field will fill all available horizontal space of it's parent container when expanded.
* @since 1.6.0
Expand Down Expand Up @@ -5714,6 +5746,22 @@ declare namespace LocalJSX {
* @since 2.1.0
*/
interface IxDateDropdown {
/**
* Button with no background or outline
*/
"buttonGhost"?: boolean;
/**
* Loading button
*/
"buttonLoading"?: boolean;
/**
* Outline button
*/
"buttonOutline"?: boolean;
/**
* button variant
*/
"buttonVariant"?: ButtonVariant1;
/**
* Controls whether the user is allowed to pick custom date ranges in the component. When set to 'true', the user can select a custom date range using the date picker. When set to 'false', only predefined time date ranges are available for selection.
*/
Expand Down Expand Up @@ -6321,6 +6369,22 @@ declare namespace LocalJSX {
"selected"?: boolean;
}
interface IxExpandingSearch {
/**
* Button with no background or outline
*/
"buttonGhost"?: boolean;
/**
* Loading button
*/
"buttonLoading"?: boolean;
/**
* Outline button
*/
"buttonOutline"?: boolean;
/**
* button variant
*/
"buttonVariant"?: ButtonVariant1;
/**
* If true the search field will fill all available horizontal space of it's parent container when expanded.
* @since 1.6.0
Expand Down
Loading
Loading