Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sloppy code mixing int and size_t after cc1 no more supporting -Wno-shorten-64-to-32 #58

Merged
merged 12 commits into from
Feb 5, 2024

Conversation

DDvO
Copy link
Member

@DDvO DDvO commented Jan 16, 2024

This is not yet meanwhile complete.
We meanwhile also added other related fixes to Makefile_v1 and CMakeLists.txt
and added a couple of comments to config_update.c.

@DDvO DDvO added enhancement New feature or request cleanup labels Jan 16, 2024
Copy link
Member Author

@DDvO DDvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments

Makefile_v1 Show resolved Hide resolved
src/util/log.c Outdated Show resolved Hide resolved
src/certstatus/crl_mgmt.c Outdated Show resolved Hide resolved
src/certstatus/crl_mgmt.c Outdated Show resolved Hide resolved
src/config/config_update.c Outdated Show resolved Hide resolved
src/config/config_update.c Outdated Show resolved Hide resolved
@DDvO DDvO marked this pull request as ready for review January 25, 2024 16:31
Copy link
Member Author

@DDvO DDvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine now.

@DDvO
Copy link
Member Author

DDvO commented Jan 31, 2024

@benjamin-schilling could you please have a look?

@kiron-mx kiron-mx force-pushed the fix_shorten-64-to-32 branch from 8f6bf98 to 25e6f28 Compare February 5, 2024 10:21
@kiron-mx kiron-mx merged commit 66a78e3 into master Feb 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants