Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter wfxctl job query by group #58

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

amvasil-v
Copy link

Description

Fix wfxctl --group filtering option so it correctly accepts a list of group names.
Currently the group filter is ignored because of the wrong type of the argument.
Add bash CLI tests for wfxctl --group option.

Issues Addressed

List and link all the issues addressed by this PR.

Change Type

Please select the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established code style, patterns, and best practices.
  • I have added tests that demonstrate the effectiveness of my changes.
  • I have updated the documentation accordingly (if applicable).
  • I have added an entry in the CHANGELOG to document my changes (if applicable).

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #58 (4074629) into main (4d3f091) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files          80       80           
  Lines        3023     3023           
=======================================
  Hits         2382     2382           
  Misses        464      464           
  Partials      177      177           
Files Coverage Δ
cmd/wfxctl/cmd/job/query/query.go 80.43% <100.00%> (ø)

Fix wfxctl --group filtering option so it correctly accepts a list of group names.
Add bash tests for wfxctl --group option.

Signed-off-by: Alexander Vasiliev <[email protected]>
Signed-off-by: Michael Adler <[email protected]>
@michaeladler michaeladler force-pushed the fix/wfxctl-group-filter branch from ed9105f to 4074629 Compare October 18, 2023 12:57
@michaeladler
Copy link
Member

Thanks for your contribution!

@michaeladler michaeladler merged commit 03e3a4f into siemens:main Oct 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants