Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: standardize logging behavior for write operations #62

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

michaeladler
Copy link
Member

@michaeladler michaeladler commented Oct 27, 2023

Description

  • Log Info() for all operations modifying (create, update, delete) storage
  • Remove some redundant Debug log messages

Issues Addressed

List and link all the issues addressed by this PR.

Change Type

Please select the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established code style, patterns, and best practices.
  • I have added tests that demonstrate the effectiveness of my changes.
  • I have updated the documentation accordingly (if applicable).
  • I have added an entry in the CHANGELOG to document my changes (if applicable).

@michaeladler michaeladler requested a review from stormc as a code owner October 27, 2023 07:27
@michaeladler michaeladler force-pushed the refactor/logging branch 2 times, most recently from c3d4529 to 0974b92 Compare October 27, 2023 09:00
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #62 (57c23e2) into main (9cd2078) will increase coverage by 0.47%.
The diff coverage is 91.42%.

❗ Current head 57c23e2 differs from pull request most recent head 8b37bda. Consider uploading reports for the commit 8b37bda to get more accurate results

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   78.73%   79.21%   +0.47%     
==========================================
  Files          80       80              
  Lines        3029     3026       -3     
==========================================
+ Hits         2385     2397      +12     
+ Misses        465      456       -9     
+ Partials      179      173       -6     
Files Coverage Δ
api/northbound.go 100.00% <100.00%> (ø)
internal/handler/job/delete.go 100.00% <100.00%> (ø)
internal/handler/job/tags/add.go 100.00% <100.00%> (+40.00%) ⬆️
internal/handler/job/tags/delete.go 100.00% <100.00%> (+40.00%) ⬆️
internal/handler/workflow/create.go 36.36% <100.00%> (+6.36%) ⬆️
internal/handler/workflow/delete.go 100.00% <100.00%> (ø)
internal/handler/job/definition/update.go 82.60% <50.00%> (-0.73%) ⬇️
internal/handler/job/status/update.go 78.84% <77.77%> (-3.70%) ⬇️

... and 1 file with indirect coverage changes

@michaeladler michaeladler force-pushed the refactor/logging branch 2 times, most recently from cdf0f84 to 57c23e2 Compare October 27, 2023 09:53
Signed-off-by: Michael Adler <[email protected]>
- Log `Info()` for all operations modifying (create, update, delete) storage
- Remove some redundant Debug log messages
- Improve error message when workflow name is not unique

Signed-off-by: Michael Adler <[email protected]>
@stormc stormc merged commit fb09d3a into siemens:main Oct 30, 2023
11 checks passed
@michaeladler michaeladler deleted the refactor/logging branch October 31, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants