Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Minimal Base Refactor #1531

Merged
merged 2 commits into from
Mar 8, 2024
Merged

tests: Minimal Base Refactor #1531

merged 2 commits into from
Mar 8, 2024

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented Mar 8, 2024

#1525 is being incredibly tricky to land. I want to start with a smaller subset of the changes to unblock things then circle back around to it.

@V-FEXrt V-FEXrt requested a review from ag-eitilt March 8, 2024 18:51
Copy link
Collaborator

@ag-eitilt ag-eitilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as good as it did in the larger PR, though I did notice a series of very minor capitalization issues.

tests/tests.wake Outdated Show resolved Hide resolved
tests/tests.wake Outdated Show resolved Hide resolved
tests/tests.wake Outdated Show resolved Hide resolved
tests/tests.wake Outdated Show resolved Hide resolved
tests/tests.wake Outdated Show resolved Hide resolved
@V-FEXrt V-FEXrt merged commit 00115b5 into master Mar 8, 2024
12 checks passed
@V-FEXrt V-FEXrt deleted the minimal-test-refactor branch March 8, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants