rsc: Delete multiple blob files per task by config #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinschmidt
approved these changes
Sep 25, 2024
| pub chunk_size: u32, | ||
| // Maximum number of files to delete from the disk per task | ||
| pub file_chunk_size: usize, |
There was a problem hiding this comment.
Is usize always going to be less than u32?
There was a problem hiding this comment.
no usize is the number of bits a pointer on the host has (so pretty much u64 everywhere). The API that the value goes into expects a usize so it was easier to let the config system do validation instead of pushing it all the way into the eviction task
Co-authored-by: Colin Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blob file deletion previously launched a task per file. This has significant overhead when deleting 100s of thousands of files.
This change allows the config to specify how many files should be deleted per task