Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsc: Tag dbblob files with their blob id #1665

Merged
merged 2 commits into from
Oct 18, 2024
Merged

rsc: Tag dbblob files with their blob id #1665

merged 2 commits into from
Oct 18, 2024

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented Oct 16, 2024

When writing a db backed blob file to disk, include the blob id in the file name for better inspection.

ag-eitilt
ag-eitilt approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@ag-eitilt ag-eitilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm not requested for review, but seems reasonable to me.

@V-FEXrt V-FEXrt merged commit 799f7a0 into master Oct 18, 2024
11 checks passed
@V-FEXrt V-FEXrt deleted the rsc-dbblob-id branch October 18, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ag-eitilt ag-eitilt ag-eitilt approved these changes

@colinschmidt colinschmidt Awaiting requested review from colinschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@V-FEXrt @ag-eitilt