Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that global core:version is present. #55

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Validate that global core:version is present. #55

merged 1 commit into from
Apr 12, 2024

Conversation

anarkiwi
Copy link
Contributor

@anarkiwi anarkiwi commented Apr 5, 2024

See #54.

@Teque5
Copy link
Collaborator

Teque5 commented Apr 6, 2024

This PR is OKAY but if no metadata is specified the version should be set.

You can add a line near if metadata is None: to set that default 1.0.0 value.

@anarkiwi
Copy link
Contributor Author

anarkiwi commented Apr 7, 2024

Thanks! Updated.

Teque5
Teque5 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@Teque5 Teque5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Teque5 Teque5 merged commit 1b03f63 into sigmf:main Apr 12, 2024
3 checks passed
@Teque5 Teque5 mentioned this pull request Apr 12, 2024
Closed
@james-pcdr james-pcdr mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teque5 Teque5 Teque5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anarkiwi @Teque5