-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add postman tests #245
add postman tests #245
Conversation
davixcky
commented
Jul 10, 2024
- add basic postman check
- add postman runner
- add basic postman test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tried to run this as signadot job submit --attach -f ./.signadot/testing/integration-test-job.yaml --set branch=main --set namespace=hotrod-istio --set sandbox=
, I got:
error: collection could not be loaded
unable to read data from file "postman/hotrod.postman_collection.json"
ENOENT: no such file or directory, open 'postman/hotrod.postman_collection.json'
Is there some missing change?
routingContext: | ||
sandbox: "@{sandbox}" | ||
uploadArtifact: | ||
- path: hotrod/playwright-report/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These paths should be postman
@@ -0,0 +1,24 @@ | |||
spec: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename this file to postman-test-job.yaml
} | ||
}, | ||
"url": { | ||
"raw": "http://frontend.hotrod-istio.svc:8080/dispatch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears to be hardcoding this variable - can you make this var be derived from the @{namespace} similar to what you did with playwright?
You are using the wrong branch, you should use |
Ah, you're right. That worked. The other comments are still outstanding however. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks