Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add postman tests #245

Merged
merged 6 commits into from
Jul 12, 2024
Merged

add postman tests #245

merged 6 commits into from
Jul 12, 2024

Conversation

davixcky
Copy link
Contributor

  • add basic postman check
  • add postman runner
  • add basic postman test

@davixcky davixcky requested a review from foxish July 10, 2024 19:37
@davixcky davixcky marked this pull request as ready for review July 10, 2024 19:37
Copy link
Member

@foxish foxish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried to run this as signadot job submit --attach -f ./.signadot/testing/integration-test-job.yaml --set branch=main --set namespace=hotrod-istio --set sandbox=, I got:

error: collection could not be loaded
  unable to read data from file "postman/hotrod.postman_collection.json"
  ENOENT: no such file or directory, open 'postman/hotrod.postman_collection.json'

Is there some missing change?

routingContext:
sandbox: "@{sandbox}"
uploadArtifact:
- path: hotrod/playwright-report/index.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These paths should be postman

@@ -0,0 +1,24 @@
spec:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename this file to postman-test-job.yaml

}
},
"url": {
"raw": "http://frontend.hotrod-istio.svc:8080/dispatch",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to be hardcoding this variable - can you make this var be derived from the @{namespace} similar to what you did with playwright?

@davixcky
Copy link
Contributor Author

When I tried to run this as signadot job submit --attach -f ./.signadot/testing/integration-test-job.yaml --set branch=main --set namespace=hotrod-istio --set sandbox=, I got:

error: collection could not be loaded
  unable to read data from file "postman/hotrod.postman_collection.json"
  ENOENT: no such file or directory, open 'postman/hotrod.postman_collection.json'

Is there some missing change?

You are using the wrong branch, you should use branch=add-postman-tests

@foxish
Copy link
Member

foxish commented Jul 12, 2024

add-postman-tests

Ah, you're right. That worked. The other comments are still outstanding however.

Copy link
Member

@foxish foxish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@davixcky davixcky merged commit 00b7b30 into main Jul 12, 2024
6 checks passed
@davixcky davixcky deleted the add-postman-tests branch July 12, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants