Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tools for accessibility and end to end testing, restructure repo for more images, reinstate CI #1

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

tomgp
Copy link

@tomgp tomgp commented Jun 11, 2021

We want to be able to test performance, accessibility, and run automated end to end testing on sites

Installing chrome/ puppeteer etc during CI

  1. Can significantly add to the build time
  2. I can never get it to work 😄

So this PR adds the required tooling to the Docker image: Chrome, associated font rendering packages and then pa11y-ci which installs Puppeteer as a dependency.

Note setting PUPPETEER_SKIP_CHROMIUM_DOWNLOAD to true so that pa11y etc. won't try to install the latest version which apparently won't work with Alpine

Copy link
Contributor

@marcelkornblum marcelkornblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tihnk it'd be worth doing this as a new image other than base - though we need to restructure the folders to make that happen (which I'm in favour of anyway)

@marcelkornblum marcelkornblum changed the title Add tools for accessibility and end to end testing Add tools for accessibility and end to end testing, restructure repo for more images, reinstate CI Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants