Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant call to IOHIDManagerSetDeviceMatching #414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gruseski
Copy link

@gruseski gruseski commented Dec 6, 2018

This line causes a segmentation fault when multiple threads call hid_enumerate() without calling hid_exit(). The function is already being called by init_hid_manager().

@Youw
Copy link

Youw commented Dec 7, 2018

hidapi is not thread-safe. You should sync it with mutex, or smth.

@Youw
Copy link

Youw commented Dec 7, 2018

At least device creation and closing.

erikolofsson pushed a commit to Malterlib/hidapi that referenced this pull request May 14, 2022
- a straight-forward build matrix for Appveyor;
- MSBuild builds with Github Actions;
- Visual Studio 2022 support for `.sln` (toolset v143);
- gather Windows build artifacts with Github actions;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants