Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using vectorResource in Call Link's Fragments #13911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Using vectorResource in Call Link's Fragments #13911

wants to merge 1 commit into from
+55 −7

Conversation

Sagar0-0
Copy link
Contributor

Closes #13887

First time contributor checklist

Contributor checklist

  • Device Realme GT Neo 3t, Android 14
  • Device Infinix Hot 20 Pro, Android 14
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Using icon: ImageVector? as a mandatory parameter to avoid conflicts in all places.

greyson-signal
greyson-signal approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@greyson-signal greyson-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks! This will go in 7.31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greyson-signal greyson-signal greyson-signal approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid using painterResource to prevent unnecessary recompositions
2 participants
@Sagar0-0 @greyson-signal