Remove Hamcrest from project files #13918
Open
+7
−2,815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234
syntaxDescription
We recently removed references to Hamcrest in the test files. This is the last bit of cleanup to remove it from the project files.
Hamcrest is still brought into this project as a transitive dependency of JUnit 4.x. So I've retained the licensing notice since it is in the classpath closure. But, it is no longer in any
build.gradle
.To update the
verification-metadata.xml
, I didperl -0777 -pi -e 's|<components>.*?</components>|<components>\n</components>|gs' gradle/verification-metadata.xml ./gradlew qa --write-verification-metadata sha256
(And then added back the mysterious
junit-bom
...)