Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hamcrest from project files #13918

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamesonwilliams
Copy link
Contributor

@jamesonwilliams jamesonwilliams commented Jan 17, 2025

Contributor checklist

  • MacBook
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

We recently removed references to Hamcrest in the test files. This is the last bit of cleanup to remove it from the project files.

Hamcrest is still brought into this project as a transitive dependency of JUnit 4.x. So I've retained the licensing notice since it is in the classpath closure. But, it is no longer in any build.gradle.

To update the verification-metadata.xml, I did

perl -0777 -pi -e 's|<components>.*?</components>|<components>\n</components>|gs' gradle/verification-metadata.xml 
./gradlew qa --write-verification-metadata sha256 

(And then added back the mysterious junit-bom...)

@greyson-signal
Copy link
Contributor

Awesome, thank you! That verification-metadata.xml update script is also clever, I'll stash that away somewhere :) Only downside is that there's one dependency (aapt) that has specific osx/linux/windows variants, so gotta add those back (already did it), but that's not that bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants