fixing RealtimeSleepTimer to work in concurrent threads #9170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id and renaming it to AlarmSleepTimer
|
Thanks, please sign our Contributor License Agreement. |
|
@theBoatman thank you very very much for the patch. Maybe now I can finally use the official release! ❤️ |
|
@theBoatman Thank you! I'm well aware that it took us a (very) long time to get to this, so thank you for sticking with it ❤️ |
|
@greyson-signal I am glad that I could help and happy that it is finally done. My final question on this topic is: Are you and @alan-signal interested in further patches for the gappless code? I am sure that there are more problems or things that could be better. (I have at least two minor things in mind to take a closer look at.) Does it make sense to make further pull requests even if the addressed problems are not as important as this one here? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the reincarnation of signalapp/libsignal-service-java#70 because @alan-signal requested the following changes:
For any other info on this change please read original request, and especially alans post.
I provided a test build if anyone wants to try it out.
If there is any problem or the need for further changes feel free to ask.
First time contributor checklist