Skip to content

Commit

Permalink
Bump nodejs from v2.9.0 to v2.11.0 in helm-charts/splunk-otel-collect…
Browse files Browse the repository at this point in the history
…or/values.yaml (#1352)

* Update nodejs instrumentation version

* relax comparisons to ignore new attributes

---------

Co-authored-by: jvoravong <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
  • Loading branch information
3 people authored Aug 21, 2024
1 parent 6b3e663 commit 62cfd9b
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 3 deletions.
12 changes: 12 additions & 0 deletions .chloggen/update-nodejs.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
component: operator
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Bump nodejs to v2.11.0 in helm-charts/splunk-otel-collector/values.yaml
# One or more tracking issues related to the change
issues: [1352]
# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ spec:
- name: OTEL_RESOURCE_ATTRIBUTES
value: splunk.zc.method=autoinstrumentation-apache-httpd:1.0.4
nodejs:
image: ghcr.io/signalfx/splunk-otel-js/splunk-otel-js:v2.9.0
image: ghcr.io/signalfx/splunk-otel-js/splunk-otel-js:v2.11.0
env:
- name: OTEL_RESOURCE_ATTRIBUTES
value: splunk.zc.method=splunk-otel-js:v2.9.0
value: splunk.zc.method=splunk-otel-js:v2.11.0
python:
image: ghcr.io/open-telemetry/opentelemetry-operator/autoinstrumentation-python:0.44b0
env:
Expand Down
6 changes: 6 additions & 0 deletions functional_tests/functional_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,12 @@ func testNodeJSTraces(t *testing.T) {
ptracetest.IgnoreResourceAttributeValue("host.arch"),
ptracetest.IgnoreResourceAttributeValue("telemetry.sdk.version"),
ptracetest.IgnoreResourceAttributeValue("splunk.distro.version"),
ptracetest.IgnoreResourceAttributeValue("process.runtime.version"),
ptracetest.IgnoreResourceAttributeValue("process.command"),
ptracetest.IgnoreResourceAttributeValue("process.command_args"),
ptracetest.IgnoreResourceAttributeValue("process.executable.path"),
ptracetest.IgnoreResourceAttributeValue("process.owner"),
ptracetest.IgnoreResourceAttributeValue("process.runtime.description"),
ptracetest.IgnoreResourceAttributeValue("splunk.zc.method"),
ptracetest.IgnoreSpanAttributeValue("net.peer.port"),
ptracetest.IgnoreSpanAttributeValue("http.user_agent"),
Expand Down
2 changes: 1 addition & 1 deletion helm-charts/splunk-otel-collector/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1195,7 +1195,7 @@ operator:
tag: v1.32.3
nodejs:
repository: ghcr.io/signalfx/splunk-otel-js/splunk-otel-js
tag: v2.9.0
tag: v2.11.0
dotnet:
repository: ghcr.io/signalfx/splunk-otel-dotnet/splunk-otel-dotnet
tag: v1.6.0
Expand Down

0 comments on commit 62cfd9b

Please sign in to comment.