Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to disable suggestion selection #440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mastrix
Copy link

@mastrix mastrix commented Oct 9, 2020

Added support to disable mention suggestion, it's useful when you need to display the whole list but disable the ability to select smbdy.

Checklist (remove this list before you submit the PR)

  • Are there tests for the new code? -

Additional review hints (remove this list before you submit the PR)
It shouldn't break any functionality as it's just preventing events.

@vercel
Copy link

vercel bot commented Oct 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/signavio/react-mentions/1kl66446c
✅ Preview: https://react-mentions-git-master.signavio.vercel.app

@codecov-io
Copy link

Codecov Report

Merging #440 into master will decrease coverage by 0.22%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   78.87%   78.64%   -0.23%     
==========================================
  Files          31       31              
  Lines         691      693       +2     
  Branches      107      109       +2     
==========================================
  Hits          545      545              
- Misses        145      147       +2     
  Partials        1        1              
Impacted Files Coverage Δ
src/MentionsInput.js 68.55% <0.00%> (-0.20%) ⬇️
src/SuggestionsOverlay.js 64.70% <0.00%> (-1.30%) ⬇️
src/Suggestion.js 85.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21005ff...4b728a9. Read the comment docs.

@kaungmyatlwin
Copy link

@jfschwarz Can you merge this PR? It's useful.

@jfschwarz
Copy link
Contributor

Sorry, I'm no longer maintaining this project.

@rimzoni
Copy link

rimzoni commented Feb 8, 2023

do we have any timeline when this feature will be released?

@jack-lewin
Copy link

Thanks @mastrix for this PR - I hope you don't mind if I try to get it merged!

--

Hey @Sigrsig and @steffektif 👋 I think you're the current maintainers as you've merged PRs in this project recently.

Would you be open to merging this if I rebase the PR & add some tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants