-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to disable suggestion selection #440
base: master
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/signavio/react-mentions/1kl66446c |
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
==========================================
- Coverage 78.87% 78.64% -0.23%
==========================================
Files 31 31
Lines 691 693 +2
Branches 107 109 +2
==========================================
Hits 545 545
- Misses 145 147 +2
Partials 1 1
Continue to review full report at Codecov.
|
@jfschwarz Can you merge this PR? It's useful. |
Sorry, I'm no longer maintaining this project. |
8265bf0
to
8dedc5d
Compare
do we have any timeline when this feature will be released? |
Thanks @mastrix for this PR - I hope you don't mind if I try to get it merged! -- Hey @Sigrsig and @steffektif 👋 I think you're the current maintainers as you've merged PRs in this project recently. Would you be open to merging this if I rebase the PR & add some tests? |
Added support to disable mention suggestion, it's useful when you need to display the whole list but disable the ability to select smbdy.
Checklist (remove this list before you submit the PR)
Additional review hints (remove this list before you submit the PR)
It shouldn't break any functionality as it's just preventing events.