-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #498 support IME with input hint along #499
base: master
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/signavio/react-mentions/CdG6DPXeS9eSF92EqMgv92z5H9PX |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 78.84% 79.14% +0.29%
==========================================
Files 32 32
Lines 695 700 +5
Branches 108 109 +1
==========================================
+ Hits 548 554 +6
+ Misses 146 145 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
8265bf0
to
8dedc5d
Compare
I too was faced with a problem that was solved by this PR. In my project, I applied this PR as a patch a few months ago and it has been working fine all along. |
@tachibanayu24 |
@manato-kawamura |
@tachibanayu24 |
Any update on this? |
|
Sorry, but I can’t provide a screenshot as I’m no longer working on the project that used this library. From what I remember, applying the fix from this PR to my project using patch-package resolved the issue. It would be ideal if this PR could be merged and a patched version released. |
@Sigrsig There is a critical issue where duplicate characters are entered during text conversion in Japanese. I tested the changes from this PR, and they successfully resolved the problem. Currently, this issue makes the product unusable for Japanese users. I strongly urge you to consider merging this PR. |
Fixes #498
What did you change (functionally and technically)? functionally