fix: use mousemove to focus suggestion #619
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fc51414 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fnky
force-pushed
the
suggestions-focus-patch
branch
from
cfe60c7
to
fc51414
Compare
Hapo-lantd
approved these changes
Oct 3, 2024
|
Why are there changes to the yarn.lock file, and is the forwardRef needed here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329
Replaces
onMouseEnterwithonMouseMoveto prevent focusing mentions underneath the cursor, unless it was moved. This solves an issue where the wrong mention would be selected regardless of the query, if the cursor was above the overlay area.While typing in the input and placing the cursor above the overlay area, should focus the matched mention. Moving the mouse over mentions should focus the mention underneath the cursor.
An edge-case that isn't always reproducible is that the previously focused mention will be focused when clearing the input, thus hiding the overlay, and typing again to show the overlay.