Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of adding mentions when using package in the shadow dom #745

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davit95
Copy link

@davit95 davit95 commented May 17, 2024

Fixes #OnSelect event for shadow dom

What I have changed?

onSelect event

  • Events only cross shadow DOM boundaries if their composed flag is set to true.
  • Some built-in events that have composed: false: Such select
  • So when I used this package in shadow root it didn't work.
  • The solution is add custom events in my microfrontend and trigger event when it is necessary passing events via detail prop
  • For this I have added listeners and called onSelect.

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: d2fbaa1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-mentions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-mentions ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 0:44am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants